Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove shard attribute, related functionality and examples #110

Merged
merged 4 commits into from
Feb 24, 2023

Conversation

yhy0217
Copy link
Contributor

@yhy0217 yhy0217 commented Feb 23, 2023

@yhy0217 yhy0217 marked this pull request as ready for review February 23, 2023 13:03
@prushforth
Copy link
Member

Addresses Maps4HTML/MapML-Specification#233

Copy link
Member

@prushforth prushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I restored the <input hidden> attribute, minus a mention of shard, because I think hidden inputs are legit, still. I am sorry to lose map-datalist, in a way, but if we ever use it the page is not deleted. I will update MapML to remove map-datalist as well.

I don't see why the image file here is deleted? Pls confirm.

@yhy0217
Copy link
Contributor Author

yhy0217 commented Feb 24, 2023

I restored the <input hidden> attribute, minus a mention of shard, because I think hidden inputs are legit, still. I am sorry to lose map-datalist, in a way, but if we ever use it the page is not deleted. I will update MapML to remove map-datalist as well.

Sounds good! :)

I don't see why the image file here is deleted? Pls confirm.

The image file demonstrates the UI of the mapml-extension, and since I changed the UI in my previous PR (to add user settings for copy operations), the image should be updated too.
I believe I have updated the image in assets\img folder when I worked on my prev PR; But seems that the english and french versions now no longer share the same assets folder, so I just updated it again for the French version documentation.

@prushforth prushforth merged commit 48afa08 into Maps4HTML:main Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove shard attribute's documentation
2 participants