Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back minimal styles required for % value height on map elements in the example(s) #25

Closed
Malvoz opened this issue Jun 29, 2021 · 1 comment · Fixed by #28
Closed

Comments

@Malvoz
Copy link
Member

Malvoz commented Jun 29, 2021

In #10 (comment) I didn't think it was necessary to add those (and other) non-required styles,
but becase body, html { height: 100%; } is required to set the map element's (or any element really) height to a % value and match the expectation I think it's a good idea to note that with the minimal styles:

<style>
  /* These styles are required if you wish to use
  a % height value on the mapml-viewer element. */
  html,
  body {
    height: 100%;
  }
</style>
@Malvoz
Copy link
Member Author

Malvoz commented Jun 29, 2021

Or this could be part of #26.

Edit: Potentially both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant