Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time <select> issues #491

Closed
Malvoz opened this issue Jul 22, 2021 · 2 comments · Fixed by #492
Closed

Time <select> issues #491

Malvoz opened this issue Jul 22, 2021 · 2 comments · Fixed by #492
Labels

Comments

@Malvoz
Copy link
Member

Malvoz commented Jul 22, 2021

The issues can be seen/reproduced in debug/select-test.html or https://maps4html.org/experiments/datacube/

  1. Can't change options in <select> using a mouse pointer
  2. <label> within <summary> eats the pointer events so it's hard to toggle <details> to view <select> (must press the tiny "disclosure triangle")
  3. HTML anatomy not consistent with opacity / style controls:

    <details class="mapml-control-layers"> <!-- opacity -->
      ...
    </details>
    <details class="mapml-control-layers"> <!-- style -->
      ...
    </details>
    <fieldset> <!-- time -->
      <details class="mapml-control-layers">
        ...
      </details>
    </fieldset>
@prushforth
Copy link
Member

Would you say this is a result of #263, in general?

@Malvoz
Copy link
Member Author

Malvoz commented Jul 22, 2021

  1. Can't change options in <select> using a mouse pointer

This is a result of only expecting <input> controls when implementing drag and drop of layers.

  1. <label> within <summary> [...]

Is generally problematic and should indeed be fixed per #263.

  1. HTML anatomy not consistent with opacity / style controls

A design choice really, but the "extra" <fieldset> I think is unnecessary and its semantics are not exposed to ATs unless the element is properly labelled anyway (e.g. using <legend> or aria-label(ledby)="").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants