Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace popup implementation with popup event #403

Open
prushforth opened this issue Apr 15, 2021 · 4 comments
Open

Replace popup implementation with popup event #403

prushforth opened this issue Apr 15, 2021 · 4 comments
Labels
accessibility API Map and associated elements' non-declarative API (events and methods) enhancement idea simplification web platform compatibility
Milestone

Comments

@prushforth
Copy link
Member

In discussions with @shepazu, he convinced us that an interactive popup for maps is likely to be one of the most difficult things to negotiate with browser developers, since it is a complex topic with accessibility requirements that likely needs to extend beyond maps use cases. Furthermore, there are discussions happening in the HTML standard that suggest a popup might become an element supported by browsers independent of maps, so maps could work towards using the results of that work and not duplicating it.

So, in accordance with that thinking, this issue is for discussion of the idea of removing a map-based popup, and replacing it with a popup event. The idea would be that the function that handles the event could create a UI appropriate to its needs, a sidebar, a toast, a popup, whatever was considered appropriate by the author. In this project we could develop a small library to handle the popup event to fit the needs of a demonstration.

Further, it may provide us opportunities for enhancing the interactivity of features returned by query links, for example, which could be used not only for popups (as they currently are, exclusively) but also for links. Currently a feature geometry can be a link, or it can have a popup, but not both; we are working on a way to return a feature with a link (by default there's currently always a popup).

@prushforth
Copy link
Member Author

prushforth commented Apr 15, 2021

When we do move to this mode, we will be in a better position to support Feature Indexing, in that feature captions that are loaded into the index can be either linked features OR popup-creators, either way the user will expose more information when activating. Currently every feature returned by the reticle is a popup creator.

@prushforth
Copy link
Member Author

@erictheise have you noticed this issue? The idea here is to simplify the overall MapML proposal by removing the need to propose UI that is associated to popups and replacing that in the proposal with an appropriate map popup event(s) API, if possible. I was persuaded in my discussions with @shepazu (not through Doug's explicit efforts to persuade me, but by my own conclusion) that negotiating maps in HTML will be made too hard /too big by bundling more requirements into the one proposal than is strictly necessary. Many others have asserted variations on this theme, by saying the overall proposal should be broken down into "primitves". As such, I think the popup event API may well be such a primitive.

In light of the fact that there is an ongoing effort led by WHATWG members to specify, polyfill and implement a <popup> element, I felt that it would be appropriate to reduce our requirements in this area, in the hope that the Web platform will be able to readily provide its own popup event handler in actual implementations, perhaps based on an evolution of the eventual <popup> element. Even if that does not turn out to be true, it is already true that popups don't suit every map use case, and so there is a need to consider an underlying API (the events, I think) first, and to potentially provide a separate and accessible custom element that implements popup behaviour that handles map popup events.

@prushforth prushforth added the API Map and associated elements' non-declarative API (events and methods) label Jul 30, 2021
@prushforth prushforth added this to the Fall term 2021 milestone Jul 30, 2021
@erictheise
Copy link
Member

Introducing a <popup> element is a great idea, glad to learn people are working on that. I didn't find any mention of maps, charts, graphs in their documents so I went ahead and asked a "dumb" question in the issue you linked @prushforth. Fall term 2021 seems optimistic for resolution of this issue though!

@prushforth
Copy link
Member Author

Fall term 2021 seems optimistic for resolution of this issue though!

I don't mean that the <popup> element will be ready by this fall.

I mean that we might be able to define the map popup event API, and perhaps a custom element that will handle it, so as to have identifiable parts to the proposal that don't all have to be addressed at once. The point is to "find the joints" of this problem and make it so we can propose and develop a solution in stages. Anyway I wanted to ensure you are aware of this notion.

I didn't find any mention of maps, charts, graphs in their documents so I went ahead and asked a "dumb" question in the issue you linked

Not dumb, very well asked. They specifically asked for feedback over here, where it is more likely to get a response, perhaps.

openui/open-ui#355

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility API Map and associated elements' non-declarative API (events and methods) enhancement idea simplification web platform compatibility
Projects
None yet
Development

No branches or pull requests

2 participants