chore!: remove job type from ctor (MAPCO-3145)#33
Merged
ronnahom96 merged 4 commits intomasterfrom May 29, 2023
Merged
Conversation
asafMasa
changed the title
asafMasa
requested changes
May 28, 2023
src/jobManagerClient.ts
Outdated
|
|
||
| public async consume<T>(taskType: string): Promise<ITaskResponse<T> | null> { | ||
| const consumeTaskUrl = `/tasks/${this.jobType}/${taskType}/startPending`; | ||
| public async consume<T>(taskType: string, jobType: string): Promise<ITaskResponse<T> | null> { |
Contributor
There was a problem hiding this comment.
please put the jobType before the task type
ronnahom96
changed the title
netanelC
approved these changes
May 29, 2023
Contributor
netanelC
left a comment
netanelC
left a comment
There was a problem hiding this comment.
You are the champion, my friend....
Good job!
RonitKissis
approved these changes
May 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.