Conversation
syncush
requested changes
Jan 26, 2026
syncush
left a comment
syncush
left a comment
There was a problem hiding this comment.
I am pretty sure most of the static content should be pushed either, it is in build time and should not be transferred via the repo
also you have helm-eyal-react; it should be totally renamed.
make sure you go over the PR before a review request
helm-eyal-react/values.yaml
Outdated
| imagePullSecretName: acr-secret | ||
|
|
||
| image: | ||
| repository: react-app-geojson-eyal |
There was a problem hiding this comment.
set a proper name, even though you get it as a task "eyal" or "task" should not be noted in an official repo in mapcolonies org
helm-eyal-react/values.yaml
Outdated
|
|
||
| image: | ||
| repository: react-app-geojson-eyal | ||
| tag: "rc13" |
There was a problem hiding this comment.
why rc13? set a proper versioning and you can take it from the package.json
public/config.json
Outdated
Comment on lines
1
to
5
| { | ||
| "token": "eyJhbGciOiJSUzI1NiIsImtpZCI6Im1hcC1jb2xvbmllcy1pbnQifQ.eyJhbyI6WyJodHRwczovL2FwcC1pbnQtY2xpZW50LXJvdXRlLWludGVncmF0aW9uLmFwcHMuajFsazNuanAuZWFzdHVzLmFyb2FwcC5pbyIsImh0dHBzOi8vYXBwLWludC1jbGllbnQtdG9vbHMtcm91dGUtaW50ZWdyYXRpb24uYXBwcy5qMWxrM25qcC5lYXN0dXMuYXJvYXBwLmlvIiwiaHR0cDovL2xvY2FsaG9zdDozMDAwIl0sImQiOlsicmFzdGVyIiwicmFzdGVyV21zIiwicmFzdGVyRXhwb3J0IiwiZGVtIiwidmVjdG9yIiwiM2QiXSwiaWF0IjoxNjc0NjMyMzQ2LCJzdWIiOiJtYXBjb2xvbmllcy1hcHAiLCJpc3MiOiJtYXBjb2xvbmllcy10b2tlbi1jbGkifQ.e-4SmHNOE8FwpcJoHdp-3Dh6D8GqCwM5wZfZIPrivGhfeKdihcsjEj_WN2jWN-ULha_ytZN5gRusLjwikNwgbF6hvb-QTDe3bEHPAjtgpZmF4HaJze8e6VPDF1tTC52CHDzNnwkUGAH1tnVGq10SnyhsGDezUChTVeBeVu-swTI58qCjemUQRw7-Q03uSEH24AkbX2CC1_rNwulo7ChglyTdn01tTWPsPjIuDjeixxm2CUmUHpfZzroaSzwof7ByQe22o3tFddje6ItNLBUC_VN7UfNLa_QPSVbIuNac-iMGFbK-RIyXUK8mp1AwddvSGsBUYcDs8fWMLzKhItljnw", | ||
| "wmtsLink": "https://tiles.mapcolonies.net/api/raster/v1/wmts/1.0.0/WMTSCapabilities.xml", | ||
| "layerName": "bluemarble-1-2-Orthophoto" | ||
| } No newline at end of file |
There was a problem hiding this comment.
This file shouldn't be committed at all
|
also fix the PR title to follow the conventional commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I Created a helm chart and a dockerfile for the geojson project deploying with the nginx-unprivileged image as webserver.