Open
Conversation
|
🎫 Related Jira Issue: MAPCO-9805 |
CL-SHLOMIKONCHA
requested changes
Feb 25, 2026
CL-SHLOMIKONCHA
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues: #XXX , #XXX ...
Closes #XXX ...
Further information:
Implement
TaskPoller- a bridge class that implementsIWorker(newjobnik-sdkinterface) using the oldmc-priority-queueSDK under the hood. It runs a polling loop over configurable(jobType, taskType)pairs, dispatches each dequeued task to a registeredITaskStrategyviaStrategyFactory, and handles ack/reject lifecycle with retry decisions fromErrorHandler.Wire up DI container - register
QueueClient,StrategyFactory,ErrorHandler, andTilesDeletionStrategyincontainerConfig.ts. The strategy DI token is now read from config (jobDefinitions.tasks.tilesDeletion.type) instead of being hardcoded, keeping it in sync with whatever the queue delivers.Add test infrastructure - introduce
tests/helpers/mocks.tswith typed mock factories (createMockQueueClient,createMockStrategyFactory,createMockErrorHandler,createTaskPoller,buildMockStrategy) andtests/helpers/fakes/with faker-based data builders (buildTask,buildPair). Allas unknown as RealTypecasting is confined tocreateTaskPoller(); test files use real SDK types andvi.mocked()for type-safe mock setup.Add
TaskPollerunit tests - 11 tests covering: stop/start lifecycle, idle loop exit, full success path (resolveWithContext → validate → execute → ack), pair error skipping, mid-loop stop on shutdown signal, max-attempts rejection, error handler decision forwarding, non-Error wrapping, reject-throws resilience, andIWorkerevent stub contract.