Merged
Conversation
asafMasa
requested changes
Jun 24, 2025
razbroc
reviewed
Jun 25, 2025
asafMasa
approved these changes
Jun 30, 2025
razbroc
reviewed
Jul 1, 2025
Contributor
razbroc
left a comment
razbroc
left a comment
There was a problem hiding this comment.
Hi Shimon.
Looks well, just a few questions.
Thank you for your service.
CL-SHLOMIKONCHA
approved these changes
Jul 2, 2025
Contributor
CL-SHLOMIKONCHA
left a comment
CL-SHLOMIKONCHA
left a comment
There was a problem hiding this comment.
Looks good - going to test it before merge on dev depoyment,
what about all those "possibly null reference." warnings?
asafMasa
requested changes
Jul 10, 2025
asafMasa
approved these changes
Jul 10, 2025
CL-SHLOMIKONCHA
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When dealing with
S3 bucketsthat contain a huge amount of objects, eachlistcommand takes a big toll on the servers.This PR reduces the use of object listing when using an
S3 client. Instead of lising, we now attempt to get the relevant object and handle the case when it doesn't exist.