This repository was archived by the owner on Oct 7, 2025. It is now read-only.
Find and read personal commands recursively, allowing dirs #1228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Friendly ping, anyone have an opportunity to review this? |
jinnatar
force-pushed
the
recursive_personal_commands
branch
from
ab1fbd5 to
8ec61ef
Compare
Contributor
Author
|
FYI, build failure is not due to this PR: |
jinnatar
force-pushed
the
recursive_personal_commands
branch
from
8ec61ef to
0e6153f
Compare
jinnatar
force-pushed
the
recursive_personal_commands
branch
from
0e6153f to
8cde535
Compare
jinnatar
force-pushed
the
recursive_personal_commands
branch
2 times, most recently
from
94cc755 to
1c5affc
Compare
jinnatar
force-pushed
the
recursive_personal_commands
branch
from
525c83e to
2c0a1d4
Compare
This allows for recursively loading personal_commands which enables flexibility in distributing them as separate directories, for example loading the ATV command library as as a submodule.
jinnatar
force-pushed
the
recursive_personal_commands
branch
from
2c0a1d4 to
10f64da
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies organisation and for example adding multiple upstream sources of commands as different directories or submodules.
Fully backwards compatible, assuming people aren't storing commands they don't want under a subdir of personal_commands.