This repository was archived by the owner on Oct 7, 2025. It is now read-only.
Remove repeated trashcan click in _clear_quests #1029
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sn0opy
added
the
hacktoberfest-accepted
Contributor
Author
|
Closing this PR as it's now obsolete with #1051 and the corresponding PD changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In earlier game versions, the confirmation dialogue to delete a quest wouldn't reliably pop up. Repeatedly clicking the trashcan symbol helped making sure we got the dialogue up.
Unfortunately, in recent game versions, clicking outside of the dialogue when it is already up causes it to close again. The repeated trashcan click is outside of the dialogue, thus it will close it and prevent confirming the deletion.
I observed this on a scanner device and confirmed it by manually trying it on my phone. Applying this fix improved the general quest scanning flow.