-
Couldn't load subscription status.
- Fork 16
Classification field, as an alternative to boolean fields for each #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Easy enough. We'll also need a related PR in Builder to support users importing this, since it's one of the fields that Builder does currently support. |
|
Don't forget to add that to the json schema |
|
I can't approve this until there's a Builder PR to support the classification field, since using it instead of the existing classification keys would cause worlds to not import correctly to Builder. |
|
Weirdly enough, the builder already supports the classification field. Internally, the builder uses item["classification"] instead of all the bools. And the way it loads the items, if that field is prepopulated, it'll just roll with the value. A round trip through the builder converts the item to the old format, but it works well enough for my liking. |
|
It's awesome that it sorta supports it, though I somewhat disagree on the quality bar. But that's kinda irrelevant because I realized... #105 added support for multiiple item classifications, which I believe was started and completed after this PR was started. So this PR would need to be updated to similarly support multiple item classifications to ensure that it can have the same information as the separate fields. Also realized we didn't get #105 to update Builder to support it. So no reason I should require any level of support for this one, either. Just feature parity in core is fine. I swear I'm not trying to find things to hold this PR up. Just unfortunate timing on this one 😅 |
|
Ran back through this because of the label. Looks like it's good to run with once it supports multiple values, to be consistent with the current multiple classification support in separate keywords. |
# Conflicts: # .gitignore # src/__init__.py
No description provided.