Skip to content

Conversation

@silasary
Copy link
Collaborator

No description provided.

@silasary silasary mentioned this pull request Oct 16, 2024
@FuzzyGamesOn
Copy link
Collaborator

This seems good. We're technically allowing unsupported syntax when we do this, though. So we have to do one of two things:

  1. Warn the user that their syntax is incorrect while we're making it work anyways.
  2. Update the schema to indicate that category can now be either a string or an array.

@FuzzyGamesOn
Copy link
Collaborator

(Also, please add a couple reviewers to your PRs so we have active reviewers on them. And since one of the reviewers has to be an admin, add me to each. 😃 )

@silasary silasary requested a review from nicopop December 2, 2024 04:11
Copy link
Contributor

@nicopop nicopop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@silasary silasary merged commit c53043f into main Dec 2, 2024
@silasary silasary deleted the cat-string branch December 2, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants