Extend hint information #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Allows you to add "entrance" information to a hint if anyone wants to do that. See https://discord.com/channels/1097532591650910289/1097538232914296944/1287149476615557142 |
|
Why not make it a json field? |
|
It sounds like one of the main uses is in randomized situations, where the location would be read from the world state. |
|
Ah, yeah, that makes sense then |
Add `after_extend_hint_information`
|
I ended up liking the json idea so I added that as an option |
FuzzyGamesOn
requested changes
Sep 24, 2024
# Conflicts resolved: # schemas/Manual.locations.schema.json
FuzzyGamesOn
approved these changes
Sep 27, 2024
FuzzyGamesOn
requested review from
nicopop and
silasary
and removed request for
silasary
|
PR only needs one more approval, so re-requesting reviews from everyone else. Last thing planned for upcoming unstable release. |
nicopop
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
extend_hint_informationandbefore_extend_hint_information