Skip to content

Convert Req functions args to real type #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 11, 2024
Merged

Convert Req functions args to real type #65

merged 3 commits into from
Jul 11, 2024

Conversation

@nicopop
Copy link
Contributor

@nicopop nicopop commented Jul 8, 2024 •
edited
Loading

like it was proposed here

TODO

  • deal with no arg type
  • maybe make datavalidation warning on conversion added support for it if we want later
  • Support complex TypingOptional only for now

@nicopop nicopop marked this pull request as ready for review July 8, 2024 17:55
@nicopop nicopop requested review from FuzzyGamesOn and silasary July 8, 2024 17:56
@nicopop
Copy link
Contributor Author

nicopop commented Jul 8, 2024 •
edited
Loading

currently break if TypingOptionnal like OptOne, working on a fix Fixed in 8834344

FuzzyGamesOn
FuzzyGamesOn approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@FuzzyGamesOn FuzzyGamesOn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 😁

@FuzzyGamesOn FuzzyGamesOn mentioned this pull request Jul 11, 2024
Merged
silasary
silasary approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@silasary silasary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy enough with this.

Technically, it's a broken implementation, as it can't handle typing.List and friends, but right now we don't support those anyway, so I'm happy to ship it and fix that if it comes up.

@FuzzyGamesOn FuzzyGamesOn merged commit 45c5cd1 into main Jul 11, 2024
@nicopop nicopop deleted the req-function-args-conversion branch September 19, 2024 16:23
@nicopop nicopop mentioned this pull request Dec 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@silasary silasary silasary approved these changes

@FuzzyGamesOn FuzzyGamesOn FuzzyGamesOn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nicopop @silasary @FuzzyGamesOn