Skip to content

Conversation

@silasary
Copy link
Collaborator

@silasary silasary commented Mar 9, 2024

For example, requiring different baits for a fish depending on where you're fishing.

There is no cost to using add_rule instead of set_rule, as AP treats it like set_rule the first time you call it on an entrance.

If you have both a requires and an entrance rule, it'll be a boolean AND.

… region cost different things based on where you're coming from.

For example, requiring different baits for a fish depending on where you're fishing.
@FuzzyGamesOn
Copy link
Collaborator

The code looks good. Worth noting that this clashes somewhat with the connects_to setting on regions (in terms of affecting entrances vs. exits), which could be a source of confusion for world creators trying to grasp how their settings affect things.

However, I think it's overall fine if we mix and match these, as long as we're explicit about which direction they're configuring -- like how connects_to is. So maybe a key like rules_from would work better, so they get used to seeing to and from to indicate which direction (entrance / exit) it affects.

@silasary
Copy link
Collaborator Author

silasary commented Mar 10, 2024

Worth noting that this clashes somewhat with the connects_to setting on regions (in terms of affecting entrances vs. exits

Yeah, I was just thinking about that.

@silasary silasary marked this pull request as draft March 12, 2024 01:45
@silasary
Copy link
Collaborator Author

Doing a bit of an overhaul to make it feel better

@silasary silasary marked this pull request as ready for review September 28, 2024 14:11
@silasary
Copy link
Collaborator Author

Finally reviving this one

Copy link
Collaborator

@FuzzyGamesOn FuzzyGamesOn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor text change for schema desc, rest looks fine 😃

@silasary silasary merged commit aca96f3 into main Oct 15, 2024
@silasary silasary deleted the entrance_rules branch December 2, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants