Skip to content

DataValidation: Bug in inaccessible non-starting region check #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 4, 2025
Merged

DataValidation: Bug in inaccessible non-starting region check #160

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ab5718
fix broken unreachable starting regions
FuzzyGamesOn Jul 3, 2025
59edb86
prevent starting false from matching as starting regions being in use
FuzzyGamesOn Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/DataValidation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,12 +397,12 @@ def checkForLocationsBeingInvalidJSON():

@staticmethod
def checkForNonStartingRegionsThatAreUnreachable():
using_starting_regions = len([region for region in DataValidation.region_table if "starting" in DataValidation.region_table[region] and not DataValidation.region_table[region]["starting"]]) > 0
using_starting_regions = len([region for region in DataValidation.region_table if DataValidation.region_table[region].get("starting")]) > 0

if not using_starting_regions:
return

nonstarting_regions = [region for region in DataValidation.region_table if "starting" in DataValidation.region_table[region] and not DataValidation.region_table[region]["starting"]]
nonstarting_regions = [region for region in DataValidation.region_table if not DataValidation.region_table[region].get("starting")]

for nonstarter in nonstarting_regions:
regions_that_connect_to = [region for region in DataValidation.region_table if "connects_to" in DataValidation.region_table[region] and nonstarter in DataValidation.region_table[region]["connects_to"]]
Expand Down