Skip to content

fix the item counts for location requirements desync with UT #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025
Merged

fix the item counts for location requirements desync with UT #150

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15842e6
create the item_counts cache earlier so UT get the precollected items
nicopop May 12, 2025
0d0ebf8
move world.get_item_counts to a more proper place
nicopop May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Rules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,8 @@ def fullLocationOrRegionCheck(state: CollectionState, area: dict):
return checkRequireStringForArea(state, area)
else: # item access is in dict form
return checkRequireDictForArea(state, area)

# calling get_item_counts here make sure the item_counts cache is created correctly for UT
world.get_item_counts(player, True)
used_location_names = []
# Region access rules
for region in regionMap.keys():
Expand Down