Skip to content

Conversation

@qwint
Copy link
Contributor

@qwint qwint commented Jan 22, 2025

to keep back compat with before 0.5.1 you can reimplement add_client_tab() ArchipelagoMW/Archipelago#3950
but that function was created so clients wouldn't have to change when kivymd gets merged so I would suggest using it for future compat

@FuzzyGamesOn
Copy link
Collaborator

Making a note that we'll need to test this to see what it changes.

@qwint
Copy link
Contributor Author

qwint commented Jan 23, 2025

Only thing it should do from a UI perspective is remove the "All" tab that duplicates the "Archipelago" tab (but obviously not stopping you from doing testing haha)

@silasary
Copy link
Collaborator

While probably not important, it's worth noting that this does move the tab to the end
image

@FuzzyGamesOn
Copy link
Collaborator

FuzzyGamesOn commented Feb 12, 2025

Ah, yeah. I figured it might do that. Have a vague memory of trying that while working on other client changes.

Yeah, to me, it's actually more important to have the Manual tab (the one that users will use the most, other than the AP tab) near the front for usability reasons. People ignore the "All" tab, anyways.

What this PR would need to solve:
If add_client_tab() or Kivy tabs in general supported adding a tab at a certain position, we could do that and this change would be a no-brainer... but when I glanced at these prior, it didn't seem like this worked or was available. Maybe this is another thing that KivyMD will fix over Kivy, no idea.

I'm also not convinced that this alone will make our client compatible with the KivyMD change, so I don't feel like we're at the point of compromising the above yet.

@FuzzyGamesOn FuzzyGamesOn self-requested a review February 12, 2025 21:21
@silasary
Copy link
Collaborator

silasary commented Apr 7, 2025

This needs to get merged because KivyMD is in core now

@FuzzyGamesOn
Copy link
Collaborator

The fact that this subtle tab change takes our CommonClient-extended client from completely broken in KivyMD to functional in KivyMD... really speaks to how much of a complete fuckery the KivyMD update in AP is.

@FuzzyGamesOn FuzzyGamesOn merged commit 9259031 into ManualForArchipelago:main Apr 7, 2025
@qwint qwint deleted the manual_tabs branch April 7, 2025 15:12
@qwint
Copy link
Contributor Author

qwint commented Jun 19, 2025

While probably not important, it's worth noting that this does move the tab to the end

FYI ArchipelagoMW/Archipelago#4876 adds an index arg to add_client_tab so it should be easy to reorient the tabs as you wish now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants