-
Couldn't load subscription status.
- Fork 16
Overhaul before_create_item hook
#131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul before_create_item hook
#131
Conversation
|
The I do like the idea of adding a simple hooks way to modify count, though. Have felt like Could we instead do this functionality as a new hook? Name can be whatever as long as it starts with |
|
Completely overhauled this PR. Now the new {"Item Name 1": 5, # <- This will create qty 5 items using all the default settings
"Item Name 2": {"useful": 7}, # <- This will create qty 7 items and force them to be classified as useful
"Item Name 3": {"progression": 2, "useful": 1}, # <- This will create 3 items, with 2 classified as progression and 1 as useful
"Item Name 4": {0b0110: 5}} # <- If you know the special flag for the item classes, you can also define non-standard options. This setup
# will create 5 items that are the "useful trap" class |
Nobody actually uses the current
before_create_itemhook, because it only lets you edit the item's name.This version adds the ability to change how many of an item are created, which is a significantly more stable way to manage dynamic item counts than the current process of removing them in
before_create_items_fillerThe old functionality is still maintained