normalization of line endings #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You probably noticed in some of my prs that the files diffs were sometime broken,
it was caused by line ending types being different on the github vs the one in the PR
this pr Should normalize the line ending of all files and thus fix future prs for everyone since this includes a .gitatribute file
By adding that file it also makes it so we dont need to tell devs to turn on
core.autocrlf trueThe diff might still break next time someone push a change in any of the normalized file unless they checkout the main after this merges
before (notice some of the file are crlf in the (i)ndex column)
after (all the files are lf in the (i)ndex column