Client: Fix bug that puts Victory in (No Category) when it has categories
#118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Category when victory location had categories
|
Oh right, we can do this now 😁 |
silasary
reviewed
Dec 15, 2024
src/ManualClient.py
Outdated
| if category not in self.listed_locations: | ||
| self.listed_locations[category] = [] | ||
|
|
||
| if len(victory_categories) == 0: |
There was a problem hiding this comment.
Is there a reason you're using len() == 0 instead of not?
There was a problem hiding this comment.
Stemmed from a misunderstanding of how for-else works in Python, which I originally did for the for loop above. In my head, for-else would do the for if there are any iterations and do the else if no iterations. In actuality, Python just like... does both if you don't break the loop. Which is kinda goofy, lol
I can change it to not 😄
axxroytovu
approved these changes
Dec 15, 2024
silasary
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an oversight in the way that victory categories are determined that appeared to only say that the victory location had categories if at least one of the categories it had was not shared by any other location.
This PR changes that behavior to instead use the categories that the victory location had defined. This also allows the Victory location button to show up in multiple categories now, and also prevents it from showing up in
(No Category)when it has categories.