Skip to content

Conversation

@nicopop
Copy link
Contributor

@nicopop nicopop commented Dec 13, 2024

Small change that make sure options added by users are compatible with python
by removing spaces in option names
Without this, spaces create some hard to understand, for non-python users, error
like this one bennydreamly got today on discord here

@nicopop nicopop self-assigned this Dec 13, 2024
@nicopop
Copy link
Contributor Author

nicopop commented Dec 14, 2024

I got additionnal changes to make it so the option display name keep the unformated option name (if its not already set by user) but I think ill keep it for a separate PR (so don't delete this branch on merge)
edit dec 13: actually idk, I simplified the additionnal code quite a bit, its basically: add a option_display_name = option_name just before both core's and user's format_to_valid_identifier override and replace option_name whenever its not used as an identifier
Edit dec 14: I'll include the changes later today Added in 0341863

@nicopop nicopop requested a review from FuzzyGamesOn December 14, 2024 01:32
@silasary silasary merged commit 4ce6a69 into main Dec 16, 2024
@silasary silasary deleted the remove-spaces-from-option-names branch December 16, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants