-
Couldn't load subscription status.
- Fork 16
Option to sort things by sort-key instead of Name #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
imo, being able to customize sorting belongs at the client level, not at the per-apworld level as a meta setting. It should be something that people can widespread apply for all their client uses and for any Manual world from the client. More for real-time sorting by the client user, not for sorting by the world creator. |
what if we let devs set a "recommended" sorting in meta.json (like this pr) and allow the players to choose to follow the devs recommendations or to override it with a setting in host.json and/or sorting buttons in client |
That would work with a client solution. World devs can have a preference -- if they would find that useful -- but shouldn't be allowed to provide a default that overrides a player's choice or default. I want to explain further so I don't come off as just preferring my own mindset or solution. The question of how we provide options for sorting comes down to the "who" and the "why" (and I think we might disagree on these):
For 1, past feature requests seem to be asking for it, and it is what I assumed we were building towards. |
|
since someone recently asked/complained about the alphabetical sorting I intend to try and implement my "dev recommended sorting" idea, ill probably starts from the code of this branch and work from there and make a new PR or something |
…Manual into dev_recommended_sorting
Changed default back to alphabetical, custom is opt-in
|
Removed the client paused label from this PR. Also, finally came around to sort-key things. Looks like #139 has incorporated the changes from this in the meantime? If so, feel free to close. If not, please clarify what's added here and will circle back to review. |
As requested by MuffinJets