Skip to content

Conversation

@silasary
Copy link
Collaborator

As requested by MuffinJets

nicopop
nicopop previously approved these changes Dec 10, 2024
@FuzzyGamesOn
Copy link
Collaborator

imo, being able to customize sorting belongs at the client level, not at the per-apworld level as a meta setting. It should be something that people can widespread apply for all their client uses and for any Manual world from the client. More for real-time sorting by the client user, not for sorting by the world creator.

@nicopop
Copy link
Contributor

nicopop commented Dec 12, 2024

imo, being able to customize sorting belongs at the client level, not at the per-apworld level as a meta setting. It should be something that people can widespread apply for all their client uses and for any Manual world from the client. More for real-time sorting by the client user, not for sorting by the world creator.

what if we let devs set a "recommended" sorting in meta.json (like this pr) and allow the players to choose to follow the devs recommendations or to override it with a setting in host.json and/or sorting buttons in client

@FuzzyGamesOn
Copy link
Collaborator

what if we let devs set a "recommended" sorting in meta.json (like this pr) and allow the players to choose to follow the devs recommendations or to override it with a setting in host.json and/or sorting buttons in client

That would work with a client solution. World devs can have a preference -- if they would find that useful -- but shouldn't be allowed to provide a default that overrides a player's choice or default.


I want to explain further so I don't come off as just preferring my own mindset or solution. The question of how we provide options for sorting comes down to the "who" and the "why" (and I think we might disagree on these):

  1. To me, the "who" is the players and the "why" is "freedom to change sort order at any time while playing to find things easier". This makes it sound like a client feature.
  2. This PR's solution seems to imply that the "who" is the world builders and the "why" is "because some of their world's locations don't make sense if they're not sorted to their preference". This makes it sound like a world JSON feature.

For 1, past feature requests seem to be asking for it, and it is what I assumed we were building towards.
For 2, I question why sorting would be the solution to the problem. (It's also worth noting that the same problem arises again once players have customizable sort controls if 2 is the solution.)

@nicopop
Copy link
Contributor

nicopop commented Feb 19, 2025

since someone recently asked/complained about the alphabetical sorting I intend to try and implement my "dev recommended sorting" idea, ill probably starts from the code of this branch and work from there and make a new PR or something

@silasary silasary changed the title Option to sort things by ID instead of Name Option to sort things by sort-key instead of Name Feb 25, 2025
@FuzzyGamesOn FuzzyGamesOn added the paused for client updates Until further notice, only bugfixes will get merged for the client label Apr 17, 2025
@FuzzyGamesOn FuzzyGamesOn removed the paused for client updates Until further notice, only bugfixes will get merged for the client label Sep 10, 2025
@FuzzyGamesOn
Copy link
Collaborator

Removed the client paused label from this PR. Also, finally came around to sort-key things.

Looks like #139 has incorporated the changes from this in the meantime? If so, feel free to close. If not, please clarify what's added here and will circle back to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants