Skip to content

Conversation

@silasary
Copy link
Collaborator

@silasary silasary commented Dec 2, 2024

Slightly improves the error messages

I currently assume that any stack trace involving UT is probably UT's fault. I can't think of a reason that wouldn't be true.

Regardless of whether UT is involved, posts the full stack trace, not just the text parameter of the exception.

Screenshot 2024-12-02 at 11 17 25 PM

nicopop

This comment was marked as resolved.

@nicopop nicopop self-requested a review December 2, 2024 22:14
Copy link
Contributor

@nicopop nicopop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. the way the popup work right now does not make it easy to copy and paste the error message path.
    maybe a copy to clipboard button could be helpful.
    that or a way to select the text to allow ctrl c
  2. when the window width is too small the errors path can go offscreen and there's no scrolling possible

@silasary
Copy link
Collaborator Author

silasary commented Dec 2, 2024

While I agree with both of these, keep in mind that all I'm doing is overriding the contents of this box:
image

I'm not quite sure how much I can push the popup without breaking AP's expectations, nor am I confident enough with kivy to do so.

Copy link
Contributor

@nicopop nicopop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair enough

@silasary silasary merged commit 4d8e449 into main Dec 3, 2024
@silasary silasary deleted the better-client-errors branch December 3, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants