Make "Invalid logic format" more descriptive for requires syntax #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ay diagnose the error based on the origin
FuzzyGamesOn
changed the title
axxroytovu
previously approved these changes
Nov 29, 2024
silasary
requested changes
Dec 1, 2024
silasary
approved these changes
Dec 2, 2024
axxroytovu
reviewed
Dec 6, 2024
axxroytovu
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this error is somewhat vague (should just say "requires", not "logic") and can be triggered from different areas for different reasons. Since this support question comes up decently often (twice today even, haha), wanted to clean this up.
This PR moves the KeyError up and identifies where the error came from. Then, based on that, we can offer some potential solutions to the error.
Also, better identifies whether the object passed into the error is a location or a region, and actually gives the region name if a region. (It didn't before this PR.)
(I wasn't sure if it was okay to use "enum" until I saw BaseClasses was. So using it 😄 )