Add search box to the client #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FuzzyGamesOn
changed the title
silasary
previously approved these changes
Dec 2, 2024
… would be more snappy
silasary
approved these changes
Dec 3, 2024
FuzzyGamesOn
requested review from
nicopop
and removed request for
axxroytovu
nicopop
approved these changes
Dec 6, 2024
axxroytovu
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From these feature suggestions:
https://discord.com/channels/1097532591650910289/1121577176886677506
https://discord.com/channels/1097532591650910289/1267280387877507154
This PR adds a search box to the Manual tab's view. When the contents of that search box change, the lists are immediately filtered to only results that have a match in the location or item name. Search only searches location/item names, and does not search categories or anything else. (Also, if you're wondering why showing/hiding is the way it is, it's because Kivy is unusable garbage and this was the easiest way to do it.)
This PR also opens the door for more filtering controls or similar, since any other controls can be added alongside the search layout.
Screenshot of Manual client after connecting, with no search term:
Screenshot of Manual client results after entering a search term:
(This screenshot shows the categories expanded so it can be seen that the term matches. The categories are not auto-expanded when a search is performed.)