Skip to content

Conversation

@silasary
Copy link
Collaborator

Not sure if we want this, but it was easy enough to throw together

image

Unfortunately, I can't put it with the others, because of how/when the launcher makes the other two.

@FuzzyGamesOn
Copy link
Collaborator

FuzzyGamesOn commented Nov 19, 2024

Hm, yeah. Normally would love to have this, but I can see the fact that it's placed above the official Discords maybe causing some drama.

They probably need to consolidate those component lists so they render all at the same time first. Then non-core stuff can add to Misc without superseding their stuff.

(Was wondering how Silvris's YAML Creator got to the bottom, and noticed it's type ADJUSTER. So if we want to have a hacky way to push it to the bottom of the list until they consolidate their lists, there's always that.)

@silasary
Copy link
Collaborator Author

Yeah, I considered putting it in Adjusters, and while it works for now, it doesn't really work on the KivyMD branch.

@FuzzyGamesOn
Copy link
Collaborator

FuzzyGamesOn commented Nov 22, 2024

Does it also show up above the normal Discord buttons in the KivyMD branch (when set to Misc)? If so, I don't think we can do this until their core components are organized better to load above any client additions.

@silasary
Copy link
Collaborator Author

Good question, I can't test until I'm home, but I'm assuming it'd still be above the rest. Let's just put it in adjusters and assume MD isn't merging any time soon

@silasary
Copy link
Collaborator Author

silasary commented Dec 1, 2024

image

Copy link
Collaborator

@FuzzyGamesOn FuzzyGamesOn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much approve

@silasary silasary merged commit 1988301 into main Dec 2, 2024
@silasary silasary deleted the discord-button branch December 2, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants