WIP Itemvalue misc fixes #101
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includes multiple small fixes to ItemValue functionality:
2586167 Fixed datavalidation to only check for requirements of used regions
63605b3 Made it so for sure that value name get lowercased (check items.py)
2b97f9d Renamed world.item_values_cache to world.itemvalue_rule_cache to stop potential confusion with world.item_values
5e64593 Stopped PreFill Datavalidation of ItemValue from reseting the world.item_values cache when running get_items_with_value so hook user can run it first then edit it to modify an item value for dev reasons
for some reason the diff of commit 63605b3 failed the only line changed in datavalidation is 249 -> 278