Skip to content

Conversation

@nicopop
Copy link
Contributor

@nicopop nicopop commented Nov 18, 2024

includes multiple small fixes to ItemValue functionality:
2586167 Fixed datavalidation to only check for requirements of used regions
63605b3 Made it so for sure that value name get lowercased (check items.py)
2b97f9d Renamed world.item_values_cache to world.itemvalue_rule_cache to stop potential confusion with world.item_values
5e64593 Stopped PreFill Datavalidation of ItemValue from reseting the world.item_values cache when running get_items_with_value so hook user can run it first then edit it to modify an item value for dev reasons

for some reason the diff of commit 63605b3 failed the only line changed in datavalidation is 249 -> 278

@nicopop nicopop self-assigned this Nov 18, 2024
@nicopop
Copy link
Contributor Author

nicopop commented Nov 18, 2024

since the first commit diff failed I might try to cherry pick the other commit in a new branch and then make a new pr idk

@FuzzyGamesOn
Copy link
Collaborator

Would love to get the item value lower fixes (63605b3) by themselves in a PR. That one's easy to digest and get through, and would fix a common issue people have with ItemValue in general.

I have to ask, though... why do they have to be lowercase?

@nicopop
Copy link
Contributor Author

nicopop commented Nov 18, 2024

Would love to get the item value lower fixes (63605b3) by themselves in a PR. That one's easy to digest and get through, and would fix a common issue people have with ItemValue in general.

I have to ask, though... why do they have to be lowercase?

@FuzzyGamesOn
Since ItemValue has been a thing Id alway .lower() the value names in some situation (like the item groups) but I forgot to do it in some places and that lead to some issues (like data validation)
all this pr above does is to make it so the actually value get lower even if the dev write Star instead of star
I could go and remove that if you prefer
ill probably redo this pr anyway for the weird diff issue

This was referenced Nov 18, 2024
@nicopop
Copy link
Contributor Author

nicopop commented Nov 18, 2024

Redid this pr without the change that bugged the diff see #104

@nicopop nicopop closed this Nov 18, 2024
@nicopop nicopop deleted the ItemValue-Misc-fixes branch November 18, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants