-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DO NOT MERGE: SBT signer sync #335
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SupremoUGH
added
the
changelog:added
Changelog: add these changes to the `added` section of the changelog
label
Apr 5, 2023
Apokalip
approved these changes
Apr 5, 2023
zqhxuyuan
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog:added
Changelog: add these changes to the `added` section of the changelog
DO-NOT-MERGE
Labels a PR that should not be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the SBT signer synchronization method. The new
sbt_sync
updates theAssetMap
and theCheckpoint
, and returns aBalanceUpdate
just likesync
, but it doesn't update theUtxoAccumulator
because you can't transfer SBTs so you don't need to generate membership proofs for them. This allows for much faster synchronization (with no Poseidon hashes computed) when dealing with SBTs.Changes were included in: #336
DO NOT MERGE
Before we can merge this PR, please make sure that all the following items have been checked off:
CHANGELOG.md
and added the appropriatechangelog
label to the PR.Files changed
in the GitHub PR explorer.CONTRIBUTING.md
.