Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: SBT signer sync #335

Closed
wants to merge 64 commits into from
Closed

DO NOT MERGE: SBT signer sync #335

wants to merge 64 commits into from

Conversation

SupremoUGH
Copy link
Contributor

@SupremoUGH SupremoUGH commented Apr 4, 2023

Adds the SBT signer synchronization method. The new sbt_sync updates the AssetMap and the Checkpoint, and returns a BalanceUpdate just like sync, but it doesn't update the UtxoAccumulator because you can't transfer SBTs so you don't need to generate membership proofs for them. This allows for much faster synchronization (with no Poseidon hashes computed) when dealing with SBTs.

Changes were included in: #336

DO NOT MERGE

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@SupremoUGH SupremoUGH changed the title Signer sbt utilities SBT sync Apr 5, 2023
@SupremoUGH SupremoUGH changed the title SBT sync SBT signer sync Apr 5, 2023
@SupremoUGH SupremoUGH self-assigned this Apr 5, 2023
@SupremoUGH SupremoUGH added the changelog:added Changelog: add these changes to the `added` section of the changelog label Apr 5, 2023
@SupremoUGH SupremoUGH marked this pull request as ready for review April 5, 2023 14:17
@SupremoUGH SupremoUGH changed the title SBT signer sync DO NOT MERGE: SBT signer sync Apr 7, 2023
@SupremoUGH SupremoUGH added the DO-NOT-MERGE Labels a PR that should not be merged label Apr 7, 2023
@SupremoUGH SupremoUGH closed this Apr 7, 2023
@SupremoUGH SupremoUGH deleted the signer_sbt_utilities branch May 24, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:added Changelog: add these changes to the `added` section of the changelog DO-NOT-MERGE Labels a PR that should not be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants