Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup CI #3

Merged
merged 8 commits into from
Oct 18, 2021
Merged

Setup CI #3

merged 8 commits into from
Oct 18, 2021

Conversation

bhgomes
Copy link
Contributor

@bhgomes bhgomes commented Oct 6, 2021

An initial CI setup for rust code checking (tests, formatting, benchmarks, ... etc.)

@bhgomes bhgomes self-assigned this Oct 6, 2021
@bhgomes bhgomes requested a review from grenade October 6, 2021 18:57
@bhgomes bhgomes added this to the manta-rs v0 milestone Oct 6, 2021
grenade
grenade previously approved these changes Oct 6, 2021
Copy link

@grenade grenade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bhgomes bhgomes requested a review from stechu October 13, 2021 22:58
@bhgomes bhgomes marked this pull request as ready for review October 13, 2021 22:59
@bhgomes
Copy link
Contributor Author

bhgomes commented Oct 13, 2021

Closes #8.

@bhgomes bhgomes linked an issue Oct 13, 2021 that may be closed by this pull request
@bhgomes bhgomes marked this pull request as draft October 14, 2021 02:56
@bhgomes bhgomes marked this pull request as ready for review October 14, 2021 03:10
Kevingislason
Kevingislason previously approved these changes Oct 14, 2021
@stechu
Copy link
Collaborator

stechu commented Oct 18, 2021

@bhgomes Can you fix all the tests?

@bhgomes
Copy link
Contributor Author

bhgomes commented Oct 18, 2021

@bhgomes Can you fix all the tests?

They won't work until we have some Rust in the library, so I want to merge this first and then we can test the real PR.

@bhgomes
Copy link
Contributor Author

bhgomes commented Oct 18, 2021

I've checked this CI on another repo, so there shouldn't be any problems that I haven't already removed.

@stechu
Copy link
Collaborator

stechu commented Oct 18, 2021

Got you.

@stechu stechu merged commit ef81679 into main Oct 18, 2021
@stechu stechu deleted the setup-ci branch October 18, 2021 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup dependabot
4 participants