Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trusted Setup Results #297

Merged
merged 23 commits into from
Jan 12, 2023
Merged

Trusted Setup Results #297

merged 23 commits into from
Jan 12, 2023

Conversation

GhostOfGauss
Copy link
Contributor

@GhostOfGauss GhostOfGauss commented Jan 4, 2023

The trusted setup is complete and so we must:

  • Update the prover and verifier keys in manta-parameters
  • Publish all ceremony data
  • Release verification tools
  • Change trusted setup ReadMe to verification instructions

The updated parameters are those generated in the final round (4328) of our trusted setup. They have been checked in the manta-pay simulation to ensure that proofs can indeed be generated and verified using them.


Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@GhostOfGauss GhostOfGauss self-assigned this Jan 4, 2023
@GhostOfGauss
Copy link
Contributor Author

@bhgomes Should we change the manta-pay simulation to load the actual parameters instead of randomly generating them? I started doing this but ran into an issue with the need to specify a temporary directory to use the manta_pay::load_parameters function, so that's a WIP. But maybe we prefer to keep using random ones in the simulation?

@GhostOfGauss
Copy link
Contributor Author

The list of contribution hashes is a reasonably small file so I decided to add it directly to this repo rather than only hosting it on the AWS s3 bucket with the other files. I placed it in manta-trusted-setup but maybe there's a better place for it?

@GhostOfGauss
Copy link
Contributor Author

@bhgomes I know you started moving the code to prepare the phase2 parameters from phase1 from manta-trusted-setup to manta-pay but I think that was never merged. For now I've added manta-pay as a dependency to manta-trusted-setup, but that's what we wanted to avoid. Should we move the prepare function to manta-pay in this PR?

@GhostOfGauss GhostOfGauss marked this pull request as ready for review January 6, 2023 15:15
Copy link
Contributor

@SupremoUGH SupremoUGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't run the verify binary myself, but I trust you did and it worked as expected, right?

@bhgomes
Copy link
Contributor

bhgomes commented Jan 10, 2023

@bhgomes Should we change the manta-pay simulation to load the actual parameters instead of randomly generating them? I started doing this but ran into an issue with the need to specify a temporary directory to use the manta_pay::load_parameters function, so that's a WIP. But maybe we prefer to keep using random ones in the simulation?

Can use something like

let directory = tempfile::tempdir().expect("Unable to generate temporary test directory.");
.

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes bhgomes merged commit d5cf096 into main Jan 12, 2023
@bhgomes bhgomes deleted the feat/ts_verifier branch January 12, 2023 03:07
@bhgomes bhgomes added the changelog:added Changelog: add these changes to the `added` section of the changelog label Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:added Changelog: add these changes to the `added` section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants