Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix asset value display #293

Merged
merged 4 commits into from
Dec 19, 2022
Merged

Fix asset value display #293

merged 4 commits into from
Dec 19, 2022

Conversation

AlexParshh
Copy link
Contributor

@AlexParshh AlexParshh commented Dec 18, 2022 •
edited
Loading

This PR adds the ability to specify how many decimals to display for AssetMetadata, which is used in manta-signer.

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@AlexParshh AlexParshh added the changelog:added Changelog: add these changes to the `added` section of the changelog label Dec 18, 2022
@AlexParshh AlexParshh marked this pull request as ready for review December 18, 2022 04:35
Apokalip
Apokalip approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@Apokalip Apokalip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgmt

@Apokalip Apokalip merged commit 4ed6388 into main Dec 19, 2022
@Apokalip Apokalip deleted the fix-asset-value-display branch December 19, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Apokalip Apokalip Apokalip approved these changes

@SupremoUGH SupremoUGH SupremoUGH approved these changes

@bhgomes bhgomes Awaiting requested review from bhgomes

@Kevingislason Kevingislason Awaiting requested review from Kevingislason

Assignees
No one assigned
Labels
changelog:added Changelog: add these changes to the `added` section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexParshh @SupremoUGH @Apokalip