Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TS Client Installation Script #267

Merged
merged 4 commits into from
Oct 10, 2022
Merged

TS Client Installation Script #267

merged 4 commits into from
Oct 10, 2022

Conversation

GhostOfGauss
Copy link
Contributor

@GhostOfGauss GhostOfGauss commented Oct 10, 2022 •
edited
Loading

Adds a convenient way for participants to download the client using curl.

The script needs to detect the user's OS and download the appropriate version of the client.

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@GhostOfGauss GhostOfGauss self-assigned this Oct 10, 2022
@GhostOfGauss GhostOfGauss marked this pull request as ready for review October 10, 2022 06:31
grenade
grenade previously approved these changes Oct 10, 2022
View reviewed changes
tools/install.sh Outdated Show resolved Hide resolved
bhgomes
bhgomes suggested changes Oct 10, 2022
View reviewed changes
tools/install.sh Outdated Show resolved Hide resolved
SupremoUGH
SupremoUGH approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@SupremoUGH SupremoUGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand it, just approving to get it merged fast.

@bhgomes bhgomes added changelog:added Changelog: add these changes to the `added` section of the changelog A-trusted-setup Area: Issues and PRs related to Trusted Setup labels Oct 10, 2022
@bhgomes bhgomes merged commit d31fe4a into main Oct 10, 2022
@bhgomes bhgomes deleted the feat/ts_download branch October 10, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SupremoUGH SupremoUGH SupremoUGH approved these changes

@bhgomes bhgomes bhgomes approved these changes

@grenade grenade Awaiting requested review from grenade

Assignees

@GhostOfGauss GhostOfGauss

Labels
A-trusted-setup Area: Issues and PRs related to Trusted Setup changelog:added Changelog: add these changes to the `added` section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GhostOfGauss @grenade @bhgomes @SupremoUGH