Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client binary #264

Merged
merged 23 commits into from
Oct 9, 2022
Merged

client binary #264

merged 23 commits into from
Oct 9, 2022

Conversation

SupremoUGH
Copy link
Contributor

@SupremoUGH SupremoUGH commented Oct 7, 2022

New:

  • Client binary
  • abstract client protocol in client.rs
  • concrete Ceremony implementation in ppot

Before approving this PR, please test the client binary exhaustively against the server on https://ceremony.manta.network, and report any unwanted behaviour.

Bug

After some testing, I noticed a bug related to Term::stdout. When the terminal is on full-screen and you are queuing, it works fine. When the terminal is not on fullscreen, the method clear_last_lines() doesn't work and the client gets infinite waiting in queue messages.
If you change the message to remove the last \n, then it works when not on fullscreen, but on FS it eats all lines above the queue message.

How do we solve this?

Closes #125


Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH SupremoUGH closed this Oct 7, 2022
@SupremoUGH SupremoUGH reopened this Oct 7, 2022
@SupremoUGH SupremoUGH marked this pull request as draft October 7, 2022 15:01
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@GhostOfGauss GhostOfGauss marked this pull request as ready for review October 7, 2022 23:00
@SupremoUGH SupremoUGH added changelog:added Changelog: add these changes to the `added` section of the changelog A-trusted-setup Area: Issues and PRs related to Trusted Setup labels Oct 8, 2022
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
SupremoUGH and others added 5 commits October 8, 2022 13:55
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes
Copy link
Contributor

bhgomes commented Oct 9, 2022

Bug

After some testing, I noticed a bug related to Term::stdout. When the terminal is on full-screen and you are queuing, it works fine. When the terminal is not on fullscreen, the method clear_last_lines() doesn't work and the client gets infinite waiting in queue messages. If you change the message to remove the last \n, then it works when not on fullscreen, but on FS it eats all lines above the queue message.

How do we solve this?

This seems resolved by the way.

GhostOfGauss
GhostOfGauss previously approved these changes Oct 9, 2022
BoyuanFeng
BoyuanFeng previously approved these changes Oct 9, 2022
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes bhgomes dismissed stale reviews from BoyuanFeng and GhostOfGauss via a3afa76 October 9, 2022 14:32
SupremoUGH and others added 4 commits October 9, 2022 17:32
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes bhgomes merged commit 720c5f6 into main Oct 9, 2022
@bhgomes bhgomes deleted the feat/client_binary branch October 9, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-trusted-setup Area: Issues and PRs related to Trusted Setup changelog:added Changelog: add these changes to the `added` section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trusted Setup Contribution CLI
4 participants