-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windowing algorithm for point multiplication #215
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhgomes
suggested changes
Aug 24, 2022
bhgomes
suggested changes
Aug 25, 2022
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
tsunrise
reviewed
Aug 31, 2022
tsunrise
suggested changes
Aug 31, 2022
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
tsunrise
previously approved these changes
Aug 31, 2022
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
bhgomes
suggested changes
Sep 7, 2022
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
bhgomes
previously approved these changes
Sep 7, 2022
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
bhgomes
previously approved these changes
Sep 7, 2022
BoyuanFeng
suggested changes
Sep 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor changes
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
bhgomes
approved these changes
Sep 7, 2022
BoyuanFeng
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-cryptography
Area: Issues and PRs related to Cryptography
A-performance
Area: Performance-related Issues and PRs
changelog:added
Changelog: add these changes to the `added` section of the changelog
P-high
Priority: High
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New:
manta-crypto
:eclair::bool.rs
: Addedselect_from_table
function with default implementation toConditionalSelect
trait.algebra.rs
: Addedadd_assign
,double_assign
andrepeated_double_assign
methods with default implementations toGroup
trait.algebra.rs
: AddedWindow
struct. The methodscalar_mul
implements windowed multiplication.algebra.rs
: Added abstract correctness testwindow_multiplication_correctness
forscalar_mul
.manta-pay
:crypto::ecc::arkworks.rs
: Implemented thePartialEq
,ConditionalSelect
andZero
traits from eclair forGroup<C>
andGroupVar
.crypto::ecc::arkworks.rs
: Addedwindowed_mul_is_correct
test which tests a concrete implementation ofWindow
for the native rust compiler.Before we can merge this PR, please make sure that all the following items have been checked off:
CHANGELOG.md
and added the appropriatechangelog
label to the PR.Files changed
in the GitHub PR explorer.CONTRIBUTING.md
.