Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Poseidon sage script #206

Merged
merged 6 commits into from
Aug 22, 2022
Merged

Move Poseidon sage script #206

merged 6 commits into from
Aug 22, 2022

Conversation

SupremoUGH
Copy link
Contributor

@SupremoUGH SupremoUGH commented Aug 18, 2022

Changes:

  • Sage script generate_parameters_grain_deterministic.sage moved from archived repo Plonk-Prototype to manta-rs.
  • Slightly modified generate_parameters_grain_deterministic_sage so it outputs the round constants for ark-ff in the desired format.
  • Added text file lfsr_values with the relevant part of the outputs.
  • Modified grain_lfsr_is_consistent in round_constants.rs so it checks every round constant and not just the first two.

Closes #84

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.
  • Ran cargo hakari generate to update the workspace-hack system

@SupremoUGH SupremoUGH added the changelog:added Changelog: add these changes to the `added` section of the changelog label Aug 18, 2022
@SupremoUGH SupremoUGH requested review from bhgomes and tsunrise August 18, 2022 20:27
@SupremoUGH SupremoUGH self-assigned this Aug 18, 2022
Copy link
Contributor

@bhgomes bhgomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please update the Poseidon README.md.

@bhgomes bhgomes merged commit 0960ab2 into main Aug 22, 2022
@bhgomes bhgomes deleted the chore/move_poseidon_sage_script branch August 22, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:added Changelog: add these changes to the `added` section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Posiedon Sage Script Here
3 participants