Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Arkworks Backend to manta-crypto #180

Merged
merged 18 commits into from
Aug 5, 2022
Merged

Add Arkworks Backend to manta-crypto #180

merged 18 commits into from
Aug 5, 2022

Conversation

bhgomes
Copy link
Contributor

@bhgomes bhgomes commented Jul 23, 2022 •
edited
Loading

  • Add Basic Crate Re-export and Canonical Dependencies
  • Add Sampling methods for fields and curves
  • Move some R1CS and algebra code from manta-pay to manta-crypto
  • Move Pairing abstraction from manta-trusted-setup to manta-crypto
  • Fix cocoon version dependency issue with a patch for now

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@bhgomes
wip: start moving arkworks to manta-crypto
50b6c10 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes bhgomes added changelog:changed Changelog: add these changes to the `changed` section of the changelog A-openzl-backend Area: Issues and PRs related to implementing OpenZL Backends labels Jul 23, 2022
@bhgomes bhgomes added this to the v1.0.0 milestone Jul 23, 2022
@bhgomes
fix: use correct ECLAIR imports
8eea657 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes
Merge branch 'main' into feat/arkworks-backend
b11d700 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes
fix: optimize dependencies with canonical versions of arkworks
3755800 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes
chore: add CHANGELOG entry
367bc9c 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes
fix: remove duplicate code migrated to manta-crypto
6df798b 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes
chore: fix import typo in disabled test
4366ef7 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes bhgomes marked this pull request as ready for review July 31, 2022 02:50
@bhgomes
chore: fix incorrect feature-flagged import
e604333 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes bhgomes mentioned this pull request Jul 31, 2022
Closed
2 tasks
@bhgomes bhgomes modified the milestones: v1.0.0, v0.6.0 Jul 31, 2022
@bhgomes
Merge branch 'main' into feat/arkworks-backend
891033d 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes
feat: add cocoon submodule
bfd667a 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes
fix: use fixed version of chacha20poly1305 crate
bf900c2 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes
fix: use fixed version of chacha20poly1305 crate
efb0e6d 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes
fix: add patch for cocoon
d7f6c78 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes
fix: remove cocoon submodule
fa75455 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes
fix: add fork raw source code
990a817 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes bhgomes modified the milestones: v0.6.0, v0.5.5 Aug 2, 2022
BoyuanFeng
BoyuanFeng suggested changes Aug 2, 2022
View reviewed changes
Cargo.toml Show resolved Hide resolved
manta-trusted-setup/Cargo.toml Show resolved Hide resolved
manta-trusted-setup/Cargo.toml Outdated Show resolved Hide resolved
manta-trusted-setup/src/groth16/test.rs Show resolved Hide resolved
manta-trusted-setup/src/util.rs Show resolved Hide resolved
manta-trusted-setup/src/util.rs Show resolved Hide resolved
manta-trusted-setup/src/util.rs Outdated Show resolved Hide resolved
@bhgomes
fix: remove dead code
03f2d6e 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes
fix: update test inclusion
b492c6b 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes bhgomes requested a review from BoyuanFeng August 2, 2022 17:14
BoyuanFeng
BoyuanFeng previously approved these changes Aug 2, 2022
View reviewed changes
GhostOfGauss
GhostOfGauss previously approved these changes Aug 5, 2022
View reviewed changes
manta-crypto/src/arkworks/constraint.rs Outdated Show resolved Hide resolved
manta-crypto/src/arkworks/constraint.rs Show resolved Hide resolved
manta-crypto/src/arkworks/constraint.rs Show resolved Hide resolved
@bhgomes bhgomes dismissed stale reviews from GhostOfGauss and BoyuanFeng via 8dc0242 August 5, 2022 14:49
@bhgomes @GhostOfGauss
chore: fix typo
8dc0242 
Co-authored-by: Todd Norton <93260651+GhostOfGauss@users.noreply.github.com>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes bhgomes merged commit f4f7da1 into main Aug 5, 2022
@bhgomes bhgomes deleted the feat/arkworks-backend branch August 5, 2022 16:03
@bhgomes bhgomes mentioned this pull request Sep 8, 2022
Open
10 tasks
@GhostOfGauss GhostOfGauss mentioned this pull request Sep 12, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GhostOfGauss GhostOfGauss GhostOfGauss approved these changes

@BoyuanFeng BoyuanFeng BoyuanFeng approved these changes

@tsunrise tsunrise Awaiting requested review from tsunrise

@SupremoUGH SupremoUGH Awaiting requested review from SupremoUGH

Assignees
No one assigned
Labels
A-openzl-backend Area: Issues and PRs related to implementing OpenZL Backends changelog:changed Changelog: add these changes to the `changed` section of the changelog
Projects
None yet
Milestone
v0.5.5
Development

Successfully merging this pull request may close these issues.
3 participants
@bhgomes @BoyuanFeng @GhostOfGauss