-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add fixed-size unsigned integer for ECLAIR #146
Conversation
Signed-off-by: Boyuan Feng <bfeng9@wisc.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BoyuanFeng and I are going to rewrite some of this (and add some bit-decomposition optimizations).
Sounds good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments on the tests. Also, @BoyuanFeng don't forget the following:
- Add generic implementation for
UnsignedInteger
from yesterday's discussion - Lets also add an unwrapping method for
UnsignedInteger
:pub fn into_inner(self) -> T { self.0 }
Add
AssertWithinRange
trait andU128
type for ECLAIR.Closes: #141
Before we can merge this PR, please make sure that all the following items have been checked off:
CHANGELOG.md
and added the appropriatechangelog
label to the PR.Files changed
in the GitHub PR explorer.CONTRIBUTING.md
.