Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add load_parameters as a library function #106

Merged
merged 4 commits into from
Jun 18, 2022
Merged

Conversation

BoyuanFeng
Copy link
Contributor

@BoyuanFeng BoyuanFeng commented Jun 17, 2022

Summary

Add load_parameters as a library function in manta-pay such that this function can be used by other Manta repos.

Details

Functions similar to load_parameters have been repeatedly implemented in several Manta repos, such as Manta, manta-signer, and cli. In this PR, we move load_parameters as a library function in manta-pay to remove code redundancy.

Issue: #100


Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@BoyuanFeng BoyuanFeng self-assigned this Jun 17, 2022
@BoyuanFeng BoyuanFeng added norelease changelog:changed Changelog: add these changes to the `changed` section of the changelog changelog:added Changelog: add these changes to the `added` section of the changelog and removed changelog:changed Changelog: add these changes to the `changed` section of the changelog labels Jun 17, 2022
@BoyuanFeng BoyuanFeng added this to the v0.6.0 milestone Jun 17, 2022
@bhgomes bhgomes modified the milestones: v0.6.0, v0.5.1 Jun 17, 2022
@bhgomes bhgomes requested review from tsunrise and bhgomes June 17, 2022 22:30
@bhgomes bhgomes requested a review from stechu June 17, 2022 22:51
@bhgomes bhgomes merged commit 8917a0d into main Jun 18, 2022
@bhgomes bhgomes deleted the feat/load-parameters branch June 18, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:added Changelog: add these changes to the `added` section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants