fix: remove download dependency from manta-benchmark
#103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix compatibility issue between
manta-benchmark
andmanta-parameters/download
.Details
openssl
is not well-supported yet inwasm
.manta-parameters
useopenssl
to download lfs files whilemanta-benchmark
containswasm
benchmarks. Currently,manta-benchmark
implicitly importsopenssl
throughmanta-pay/test
which importsmanta-parameters/download
.In this PR, we separate the feature
manta-parameters/download
frommanta-pay/test
to avoid this implicit import ofopenssl
inmanta-benchmark
.Issue: #104
Before we can merge this PR, please make sure that all the following items have been checked off:
CHANGELOG.md
and added the appropriatechangelog
label to the PR.Files changed
in the GitHub PR explorer.CONTRIBUTING.md
.