Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove download dependency from manta-benchmark #103

Merged
merged 3 commits into from
Jun 17, 2022

Conversation

BoyuanFeng
Copy link
Contributor

@BoyuanFeng BoyuanFeng commented Jun 16, 2022

Summary

Fix compatibility issue between manta-benchmark and manta-parameters/download.

Details

openssl is not well-supported yet in wasm. manta-parameters use openssl to download lfs files while manta-benchmark contains wasm benchmarks. Currently, manta-benchmark implicitly imports openssl through manta-pay/test which imports manta-parameters/download.

In this PR, we separate the feature manta-parameters/download from manta-pay/test to avoid this implicit import of openssl in manta-benchmark.

Issue: #104


Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@BoyuanFeng BoyuanFeng added the changelog:fixed Changelog: add these changes to the `fixed` section of the changelog label Jun 16, 2022
@BoyuanFeng BoyuanFeng requested review from bhgomes and tsunrise June 16, 2022 22:07
tsunrise
tsunrise previously approved these changes Jun 16, 2022
@BoyuanFeng BoyuanFeng added this to the v0.6.0 milestone Jun 16, 2022
@BoyuanFeng BoyuanFeng self-assigned this Jun 16, 2022
@bhgomes bhgomes merged commit c8f9a3f into main Jun 17, 2022
@bhgomes bhgomes deleted the fix/remove-download-dependency-bench-ci branch June 17, 2022 14:21
@bhgomes bhgomes modified the milestones: v0.6.0, v0.5.1 Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:fixed Changelog: add these changes to the `fixed` section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix compatibility issue between manta-benchmark and manta-parameters/download
4 participants