Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add trait and Poseidon implementation of permutation and sponge #101

Closed
wants to merge 16 commits into from

Conversation

tsunrise
Copy link
Contributor

@tsunrise tsunrise commented Jun 13, 2022

We plan to put implementations to #81. DO NOT MERGE THIS

Summary

Add Poseidon implementation of permutation, sponge, and duplex.

Details

  • Add PseudorandomPermutation trait and its Poseidon Implementation.
  • Hasher::untruncated now uses permute method.
  • breaking changes: parameter generation code is moved to poseidon::parameter module
  • Add crypto primitives: sponge, duplex, and duplex encryption

Closes: #99


Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@tsunrise
Copy link
Contributor Author

@bhgomes When you have time, can you do a quick sanity check on the APIs of permutation and poseidon implementation?

@tsunrise tsunrise requested a review from bhgomes June 13, 2022 20:49
@bhgomes bhgomes added the changelog:added Changelog: add these changes to the `added` section of the changelog label Jun 14, 2022
@tsunrise tsunrise marked this pull request as ready for review June 16, 2022 04:36
@tsunrise tsunrise self-assigned this Jun 16, 2022
@BoyuanFeng BoyuanFeng added this to the v0.6.0 milestone Jun 16, 2022
@tsunrise
Copy link
Contributor Author

tsunrise commented Jun 21, 2022

We plan to put implementations to #81. DO NOT MERGE THIS

@tsunrise tsunrise marked this pull request as draft June 21, 2022 01:07
@bhgomes bhgomes removed this from the v0.5.2 milestone Jun 21, 2022
@tsunrise
Copy link
Contributor Author

implementation in #81 works better imo, close this for now

@tsunrise tsunrise closed this Jun 21, 2022
@tsunrise tsunrise deleted the feat/perm branch June 28, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:added Changelog: add these changes to the `added` section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup Poseidon as a Permutation
3 participants