-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add concurrency groups to the relevant workflows #653
Conversation
Please signoff on all commits with your name, email and gpg key for the Developer's Certificate of Origin. |
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
cc45f85
to
07afcc2
Compare
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
094dd2a
to
503e8ba
Compare
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the much needed yamllint along with this nice improvement.
Pls add .ds_store to .gitignore so it won't get recommitted
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TFTPR!
* fix: add concurrency groups to the relevant workflows Signed-off-by: Brandon H. Gomes <bhgomes@pm.me> * chore: add CHANGELOG entry Signed-off-by: Brandon H. Gomes <bhgomes@pm.me> * feat: add yamllint configuration for our style choices Signed-off-by: Brandon H. Gomes <bhgomes@pm.me> * fix: add `.DS_Store` to `.gitignore` Signed-off-by: Brandon H. Gomes <bhgomes@pm.me> Signed-off-by: Shumo Chu <shumo.chu@pm.me>
Description
Explicitly labeling concurrency groups allows actions to be canceled if they are not the latest run in a concurrency group. For PRs this means if a workflow is running and a new commit spawns a concurrent workflow the original workflow is canceled. This reduces total CI cost since useless runs are canceled immediately.
.github/workflows/check_build.yml
.github/workflows/check_tests.yml
.github/workflows/publish_draft_releases.yml
yamllint
configuration file for our common workflow writing stylecloses: #640
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
<branch>/CHANGELOG.md
Files changed
in the Github PR explorer.authoring_version
: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.spec_version
: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.impl_version
: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.transaction_version
: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. You can run themetadata_diff.yml
workflow for help. If this number is updated, then thespec_version
must also be updatedBaseFilter
. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime
. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]
items to check for any.