-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consensus migration stage 1: Enable Nimbus-Aura #582
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
…anta-Network/Manta into ghzlatarev/refactor-transactor
Garandor
added
the
C-enhancement
Category: An issue proposing an enhancement or a PR with one
label
Jun 8, 2022
Garandor
added
the
A-client
Client - i.e. not upgradeable with the runtime - changes
label
Aug 4, 2022
Garandor
force-pushed
the
garandor/nimbus
branch
from
August 4, 2022 21:34
9281e92
to
c59950c
Compare
Signed-off-by: Adam Reif <Garandor@manta.network>
Garandor
force-pushed
the
garandor/nimbus
branch
from
August 4, 2022 21:53
dc12ea6
to
329b22b
Compare
This reverts commit 6afb884.
Signed-off-by: Adam Reif <Garandor@manta.network>
Garandor
force-pushed
the
garandor/nimbus
branch
from
August 5, 2022 16:50
b476fa6
to
2314953
Compare
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Dengjianping
reviewed
Aug 8, 2022
ghzlatarev
reviewed
Aug 8, 2022
ghzlatarev
reviewed
Aug 8, 2022
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
ghzlatarev
previously approved these changes
Aug 9, 2022
Dengjianping
reviewed
Aug 9, 2022
Signed-off-by: Adam Reif <Garandor@manta.network>
…imbus Signed-off-by: Adam Reif <Garandor@manta.network>
ghzlatarev
approved these changes
Aug 9, 2022
Dengjianping
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-calamari
Area: Issues and PRs related to the Calamari Runtime
A-client
Client - i.e. not upgradeable with the runtime - changes
A-consensus
Area: Issues and PRs related to Consensus
A-dolphin
Area: Issues and PRs related to the Dolphin Runtime
A-runtime
Area: Issues and PRs related to Runtimes
C-enhancement
Category: An issue proposing an enhancement or a PR with one
L-changed
Log: Issues and PRs related to changes
P-high
Priority: High
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables Nimbus-Aura consensus for Dolphin as stage 1 of #486
It creates a 3-step author filter pipeline:
SessionKeys
followup to #668
addresses #669
fixes #612
NOTE:
docker-image-test
is expected as this is a consensus-breaking change. The new client is incompatible with the currently deployed state of the calamari chain and will only work when the chain runtime is upgraded.polkadot-js/api
. The submitted PR is: Extend getAuthorDetails to handle Nimbus for the MantaNetwork usecase polkadot-js/api#5142Todo:
[ ] remove left-over mentions of auraCan't do this as we still use the Aura session key until we migrate away
service_nimbus
back intoservice
, leave old aura service used for manta asservice_aura
manta
runtime to nimbus left for a followup issue