-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiply tx len and base fee component by max number of remarks per block, in the fees calculation of congested_chain_simulation
test
#536
Conversation
Signed-off-by: ghzlatarev <ghzlatarev@gmail.com>
congested_chain_simulation
test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Does it affect the congestion? Worse or better? |
The length component doesn't add much. Around $500 at the end of the day. |
congested_chain_simulation
testcongested_chain_simulation
test
Signed-off-by: ghzlatarev <ghzlatarev@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…lock, in the fees calculation of `congested_chain_simulation` test (#536) * Add len fee to the test Signed-off-by: ghzlatarev <ghzlatarev@gmail.com> * Comment Signed-off-by: ghzlatarev <ghzlatarev@gmail.com> * Consistent use of safe math Signed-off-by: ghzlatarev <ghzlatarev@gmail.com> Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
…lock, in the fees calculation of `congested_chain_simulation` test (#536) * Add len fee to the test Signed-off-by: ghzlatarev <ghzlatarev@gmail.com> * Comment Signed-off-by: ghzlatarev <ghzlatarev@gmail.com> * Consistent use of safe math Signed-off-by: ghzlatarev <ghzlatarev@gmail.com> Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: ghzlatarev ghzlatarev@gmail.com
Description
closes: #530
congested_chain_simulation
because when ApplyWeightToFeePolynomial
s topallet_transaction_payment
's length fee paritytech/substrate#10785 lands in 0.9.18 it might not be so negligible to ignore. It adds $500 to the result cost.remarks
in a TX and multiply thelen
andbase_weight
components by that amount.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
<branch>/CHANGELOG.md
Files changed
in the Github PR explorer.authoring_version
: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.spec_version
: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.impl_version
: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.transaction_version
: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. You can run themetadata_diff.yml
workflow for help. If this number is updated, then thespec_version
must also be updatedBaseFilter
. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime
. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]
items to check for any.