-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update upstream to v0.9.15 #359
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@Garandor Can you take a look whether the concern you raised is addressed? It looks to be addressed to me. |
My main concern is that using If system is running any hooks, its invocation could be duplicated - e.g. logs could be written twice if executed on hook. The rest LGTM |
What you are looking for are the diffs in frame/executive/src/lib.rs and frame/support/procedural/src/construct_runtime/mod.rs
and then how it is used in Executive:
When before it was actually referring to system pallet explicitly:
This is why there is no double execution. System is no longer called explicitly. but as part of the set from |
Ok got it, since the behavior of executive changed to not explicitly execute System, it is not a concern. Thanks @ghzlatarev |
* Bump deps to polkadot-v0.9.15 * Use old AllPalletsReversedWithSystemFirst order Co-authored-by: ghzlatarev <ghzlatarev@gmail.com>
Description
Update upstream to v0.9.15
closes: #351
Calamari/Manta Runtime
Hook order execution is now more explicit hook change, The pr tells more details about the change.
For now we will use
AllPalletsReversedWithSystemFirst
which will preserve old behaviour and we don't have to reorder our pallets in consstruct_runtime!At some point we should migrate to AllPalletsWithSystem - #378
Calamari/Manta Client
None.
Upstream Changes
Polkadot:
paritytech/polkadot@release-v0.9.13...release-v0.9.15
Substrate:
paritytech/substrate@polkadot-v0.9.13...polkadot-v0.9.15
Cumulus:
None.
paritytech/cumulus@polkadot-v0.9.13...polkadot-v0.9.15
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
manta
ordolphin
) with right title (start with [Manta] or [Dolphin]),Files changed
in the Github PR explorer.authoring_version
: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.spec_version
: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.impl_version
: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.transaction_version
: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. If this number is updated, then the spec_version must also be updatedversion
for every crate.BaseFilter
. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.