Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to v0942 polkadot binary #1193

Merged
merged 3 commits into from
Jul 10, 2023
Merged

Revert to v0942 polkadot binary #1193

merged 3 commits into from
Jul 10, 2023

Conversation

ghzlatarev
Copy link
Contributor

@ghzlatarev ghzlatarev commented Jul 10, 2023

Description

  • In v0943 polkadot release they replace ws-port with rpc-port. Thats why our integration test jobs were failing, as it breaks polkdot-launch.
  • Until we switch to zombienet we can revert to 0942 binaries so our tests can work.

Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev ghzlatarev self-assigned this Jul 10, 2023
@ghzlatarev ghzlatarev added C-enhancement Category: An issue proposing an enhancement or a PR with one A-manta Area: Issues and PRs related to the Manta Runtime A-calamari Area: Issues and PRs related to the Calamari Runtime A-runtime Area: Issues and PRs related to Runtimes L-fixed Log: Issues and PRs related to bug fixes A-testing Area: Testing-related Issues and PRs labels Jul 10, 2023
@ghzlatarev
Copy link
Contributor Author

This will need polkadot-launch fork or change CI to zombienet.

@ghzlatarev ghzlatarev closed this Jul 10, 2023
@ghzlatarev ghzlatarev changed the title Fix ws-port to rpc-port flag for integrations test polkadot v0943 binary Revert to v0943 polkadot binary Jul 10, 2023
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev ghzlatarev reopened this Jul 10, 2023
@ghzlatarev ghzlatarev marked this pull request as ready for review July 10, 2023 10:31
@ghzlatarev ghzlatarev changed the title Revert to v0943 polkadot binary Revert to v0942 polkadot binary Jul 10, 2023
@github-actions
Copy link

github-actions bot commented Jul 10, 2023

⚠️ Congestion test: 1-day congestion cost (manta-runtime) is NOT above target_daily_congestion_cost_kma

@github-actions
Copy link

github-actions bot commented Jul 10, 2023

⚠️ Congestion test: 1-day congestion cost (calamari-runtime) is NOT above target_daily_congestion_cost_kma

@ghzlatarev ghzlatarev merged commit 51038df into manta Jul 10, 2023
38 of 39 checks passed
@ghzlatarev ghzlatarev deleted the ghzlatarev/remove-ws-por branch July 10, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-manta Area: Issues and PRs related to the Manta Runtime A-runtime Area: Issues and PRs related to Runtimes A-testing Area: Testing-related Issues and PRs C-enhancement Category: An issue proposing an enhancement or a PR with one L-fixed Log: Issues and PRs related to bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants