Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-new MantaPay precomputed coins and re-enable tests #1015

Merged
merged 9 commits into from
Feb 17, 2023

Conversation

ghzlatarev
Copy link
Contributor

@ghzlatarev ghzlatarev commented Feb 9, 2023

Description

  • Recomputed the MantaPay coins used for testing using the latest MantaPay
  • Updated the tests folder to use the newly generated files
  • Re-enabled the CI tests that used the precomputed coins

Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev ghzlatarev added C-bug Category: Issues documenting a bug A-calamari Area: Issues and PRs related to the Calamari Runtime A-automation Area: Issues and PRs related to Automation A-dolphin Area: Issues and PRs related to the Dolphin Runtime L-changed Log: Issues and PRs related to changes labels Feb 9, 2023
@ghzlatarev ghzlatarev self-assigned this Feb 9, 2023
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev ghzlatarev marked this pull request as ready for review February 10, 2023 03:01
Copy link
Contributor

@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

tests/insert_coins.js Show resolved Hide resolved
ferrell-code
ferrell-code previously approved these changes Feb 10, 2023
tests/insert_coins.js Outdated Show resolved Hide resolved
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
tests/insert_coins.js Outdated Show resolved Hide resolved
tests/insert_coins.js Outdated Show resolved Hide resolved
ghzlatarev and others added 2 commits February 14, 2023 05:45
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
tests/insert_coins.js Outdated Show resolved Hide resolved
Garandor
Garandor previously approved these changes Feb 14, 2023
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
tests/insert_coins.js Show resolved Hide resolved
tests/insert_coins.js Show resolved Hide resolved
@Dengjianping Dengjianping merged commit 6719c8a into manta Feb 17, 2023
@Dengjianping Dengjianping deleted the ghzlatarev/renew-precomputed-coins branch February 17, 2023 02:15
@Garandor Garandor mentioned this pull request Feb 21, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-automation Area: Issues and PRs related to Automation A-calamari Area: Issues and PRs related to the Calamari Runtime A-dolphin Area: Issues and PRs related to the Dolphin Runtime C-bug Category: Issues documenting a bug L-changed Log: Issues and PRs related to changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants