Repository navigation
Pca remove dim_space argument - #297
Open
vbrennsteiner wants to merge 2 commits into
Open
vbrennsteiner wants to merge 2 commits into
vbrennsteiner wants to merge 2 commits into
Conversation
This was referenced Oct 8, 2026
Closed
vbrennsteiner
added this pull request to stack #300
October 8, 2026 09:18
vbrennsteiner
removed this pull request from stack #300
October 8, 2026 09:53
vbrennsteiner
changed the base branch from
main
to
pca_store_obs_and_var_names
October 8, 2026 09:55
vbrennsteiner
added this pull request to stack #302
October 8, 2026 10:00
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
The dim_space argument in pca and bpca functions allows for computing embedding son obs & var space, but adds considerable implementation complexity. Since PCA is generally understood as reducing the feature space to components, and since the rare case of embedding samples instead can be achieved by preceding the operation with a transpose, this PR removes the dim_space functionality in favor of only computing PCA and Bayesian PCA on the feature space.