Skip to content

Rename pca adata arg - #265

Draft
mschwoer wants to merge 5 commits into
mainfrom
rename-pca-adata-arg
Draft

mschwoer wants to merge 5 commits into
mainfrom
rename-pca-adata-arg

Conversation

@mschwoer

Copy link
Copy Markdown
Contributor

Separated from #243 because it touches notebooks anr probably dies not age well..

mschwoer and others added 5 commits June 30, 2026 12:44
---
# Conversation that produced these changes
---

## User prompt

"I removed all type hint exclusions, please analyze, how the issues with the type checker can be resolved."

## Clarifying round 1

Q: Which resolution path should I take for the 215 ty diagnostics?
  - Hybrid (recommended)  <-- chosen
  - Full code fix with cast
  - Restore rule ignores
  - Just the analysis

## User prompt

"still 9 diagnostics?"

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---
# Conversation that produced these changes
---

## User prompt

"I renamed the first argument in prepare_pca_1d_loadings_data_to_plot() and plot_pca_loadings(). Adapt all usages of it"

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@lucas-diedrich lucas-diedrich added the breaking-change Breaking change that changes the API label Jul 30, 2026
@lucas-diedrich

Copy link
Copy Markdown
Collaborator

@mschwoer how is this going?

@mschwoer
mschwoer marked this pull request as draft August 20, 2026 16:16
@mschwoer

Copy link
Copy Markdown
Contributor Author

@lucas-diedrich @vbrennsteiner I would wait until there's a good time for this then redo it

Base automatically changed from type-hints_II to main August 21, 2026 07:04

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change Breaking change that changes the API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants