Shameless Claude test coverage for ModificationMapper #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test coverage for: - Initialization with empty/mapping type/custom mappings - Reverse mapping creation (single and list formats) - add_modification_mapping method - UniMod extension functionality 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Test set_modification_mapping with string argument (yaml lookup path) - Test Protein_N-term vs Any_N-term precedence in reverse mapping - Test that add_modification_mapping overwrites existing key values - Clarify docstring: new keys added, existing keys overwritten 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
GeorgWa
changed the title
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive unit test coverage for the ModificationMapper class, focusing on previously untested code paths and edge cases. The tests validate initialization scenarios, mapping operations, and reverse mapping behavior.
Key Changes:
- Added 13 new test cases covering initialization, mapping updates, and reverse mapping generation
- Updated
add_modification_mappingdocstring to clarify that existing keys are overwritten rather than extended - Tests document important behaviors like
Any_N-termprecedence overProtein_N-termin reverse mappings
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/unit/psm_reader/test_modification_mapper.py | New test file with comprehensive coverage for ModificationMapper initialization, mapping operations, and edge cases |
| alphabase/psm_reader/modification_mapper.py | Clarified docstring to document that add_modification_mapping overwrites existing keys rather than extending them |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mschwoer
approved these changes
Dec 8, 2025
| ) | ||
|
|
||
| # new key is added | ||
| assert "Acetyl@K" in mapper.modification_mapping |
Contributor
There was a problem hiding this comment.
could you just assert mapper.modification_mapping == expected ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
set_modification_mappingwith string argument (yaml lookup code path)Protein_N-termvsAny_N-termprecedence in reverse mappingadd_modification_mappingoverwrites existing key values🤖 Generated with Claude Code